Repository navigation
Add field selection to ros2 topic delay - #1272
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
sylvesterkaczmarek
force-pushed
the
fix-738-topic-delay-field
branch
from
October 1, 2026 00:36
ceec4b6 to
cae0222
Compare
Contributor
Author
|
Rebased onto current rolling today and the branch is now 0 behind and mergeable, with no current failing checks. The topic-delay field selection change remains intact. Could a maintainer review the refreshed head when convenient? |
Allow ros2 topic delay to read the timestamp header from a selected sub-message, including indexed array fields such as transforms.[0]. Add focused tests for root, nested-array, and invalid field selection. Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
sylvesterkaczmarek
force-pushed
the
fix-738-topic-delay-field
branch
from
October 6, 2026 12:12
cae0222 to
fbf1216
Compare
Contributor
Author
|
retest this please |
Contributor
Author
|
Build 36 failed only in the existing ros2doctor service-count report test. The topic-delay tests passed, and this PR does not change ros2doctor. Retesting the same head. retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #738.
Add an optional
--fieldselector toros2 topic delayso the timestamp header can come from a nested sub-message instead of requiring the topic's root message to have a header.The selector follows the existing field syntax:
.selects nested fields.[index]selects array elementsExample for TF:
ros2 topic delay /tf --field transforms.[0]This keeps the implementation generic and does not special-case TF message types.
Testing
Added focused tests for:
--fieldis omittedDid you use Generative AI?
Yes. AI was used to assist with implementation and tests. I reviewed and validated the changes.